On 2019-03-07 23:02, David Fetter wrote: >> if (psql_version_is_numeric) >> return /docs/psql_version/ >> else if (psql_version ends with 'devel') >> return /docs/devel/ >> else >> return /docs/{psql_version but with text stripped}/ >> >> So that e.g. 12beta would return "12", as would 12rc or 12alpha. But >> 12devel would return "devel". > > That's exactly what I had in mind :)
The outcome of that is exactly what my patch does, but the inputs are different. We have PG_MAJORVERSION, which is always a single integer, and PG_VERSION, which could be 10.9.8 or 11beta5 or 12devel. The patch does if (PG_VERSION ends with 'devel') return /docs/devel/ else return /docs/$PG_MAJORVERSION/ There is no third case. Your third case of not-numeric-and-not-devel is correctly covered by the else branch. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services