On Wed, Mar 6, 2019 at 1:39 PM Filip Rembiałkowski <filip.rembialkow...@gmail.com> wrote: > Here is Pavel's patch rebased to master branch, added the dropdb > --force option, a test case & documentation.
Hello, cfbot.cputube.org says this fails on Windows, due to a missing semicolon here: #ifdef HAVE_SETSID kill(-(proc->pid), SIGTERM); #else kill(proc->pid, SIGTERM) #endif The test case failed on Linux, I didn't check why exactly: Test Summary Report ------------------- t/050_dropdb.pl (Wstat: 65280 Tests: 13 Failed: 2) Failed tests: 12-13 Non-zero exit status: 255 Parse errors: Bad plan. You planned 11 tests but ran 13. +/* Time to sleep after isuing SIGTERM to backends */ +#define TERMINATE_SLEEP_TIME 1 s/isuing/issuing/ But, hmm, this macro doesn't actually seem to be used in the patch. Wait, is that because the retry loop forgot to actually include the sleep? + /* without "force" flag raise exception immediately, or after 5 minutes */ Normally we call it an "error", not an "exception". -- Thomas Munro https://enterprisedb.com