Hi > Not doing the check is a bad idea as ControlFileData should be compatible > between the binary and the data read. I am attaching a fresh 0001 > which should be back-patched down to v11 as a bug fix.
Looks fine. We need add few words to documentation? >>> if (badblocks > 0) >>> return 1; >> >> Small question: why return 1 instead of exit(1)? > > OK, let's fix that on the way as part of the renaming. Was not changed?.. I have no new notes after reading updated patchset. regards, Sergei