On Sun, Mar 17, 2019 at 10:10 AM Michael Paquier <mich...@paquier.xyz> wrote:
> On Sat, Mar 16, 2019 at 11:18:17AM +0100, Magnus Hagander wrote: > > BLCKSZ is very much an internal term. The exposed name through > pg_settings > > is block_size, so I think the original was better. Combining that one > with > > yours into "initialized with block size %d" etc, makes it a lot nicer. > > Yes, what Fabien and you say here makes sense. > > > The "incompatible with pg_checksums" part may be a bit redundant with the > > commandname at the start as well, as I now realized Fabien pointed out > > downthread. But I would suggest just cutting it and saying "%s: database > > files are incompatible" or maybe "%s: data directory is incompatible" > even? > > "Cluster" is more consistent with the surroundings. So what about the > attached then? > LGTM. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
