On Tuesday, March 19, 2019 7:55 AM, Bruce Momjian <[email protected]> wrote:
> On Tue, Mar 19, 2019 at 02:43:49AM -0400, Bruce Momjian wrote: > > > > 3. Actually, I'm kind of wondering why pg_upgrade has a --new-bindir > > > option at all, rather than just insisting on finding the new-version > > > executables in the same directory it is in. This seems like, at best, > > > a hangover from before it got into core. Even if you don't want to > > > remove the option, we could surely provide a useful default setting > > > based on find_my_exec. (I'm amused to notice that pg_upgrade > > > currently takes the trouble to find out its own path, and then does > > > precisely nothing with the information.) > > > > > > > Good point. You are right that when it was outside of the source tree, > > and even in /contrib, that would not have worked easily. Makes sense to > > at least default to the same directory as pg_upgrade. > > I guess an open question is whether we should remove the --new-bindir > option completely. If the default is made to find the new-version binaries in the same directory, keeping --new-bindir could still be useful for easier testing of pg_upgrade. cheers ./daniel
