The following review has been posted through the commitfest application: make installcheck-world: tested, passed Implements feature: tested, passed Spec compliant: not tested Documentation: not tested
I read a discussion and I think so currently implemented behave (by last patch) is correct in all details. I propose maybe more strongly comment fact so noError is applied only on "not found" event. In other cases, this flag is ignored and error is raised immediately there. I think so it is not good enough commented why. This is significant change - in previous releases, noError was used like really noError, so should be commented more. Regress tests are enough. The patch is possible to apply without problems and compile without warnings The new status of this patch is: Ready for Committer
