On 2019-03-21 18:46, Marius Timmer wrote: > as I mentioned three weeks ago the patch from October 2018 did not apply > on the master. In the meantime I rebased it. Additionally I fixed some > Makefiles because a few icu-libs were missing. Now this patch applies > and compiles successfully on my machine. After installing running "make > installcheck-world" results in some failures (for example "select"). I > will take a closer look at those failures and review the whole patch in > the next few days. I just wanted to avoid that you have to do the same > rebasing stuff. The new patch is attached to this mail.
As I said previously in this thread, this patch needs some fundamental design work. I don't think it's worth doing a code review on the patch as it is. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services