On 2019-04-03 22:20:00 -0700, Andres Freund wrote: > Hi, > > On 2019-04-03 20:00:09 +1300, David Rowley wrote: > > Oops, I forgot about that one. v4 attached. > > I'm pretty happy with this. I'm doing some minor changes (e.g. don't > like the function comment formatting that much, the tableam callback > needs docs, stuff like that), and then I'm going to push it tomorrow.
After another read, I also think I'm going to rename the functions a bit. CopyMultiInsertInfo_SetupBuffer, with its mix of camel-case and underscores, just doesn't seem to mix well with copy.c and also just generally other postgres code. I feel we already have too many different naming conventions... Greetings, Andres Freund
