Michael Paquier <mich...@paquier.xyz> wrote: > On Fri, Apr 12, 2019 at 12:27:11PM +0900, Kyotaro HORIGUCHI wrote: > > This patch changes XLogRead to allow using other than > > BasicOpenFile to open a segment, and use XLogReaderState.private > > to hold a new struct XLogReadPos for the segment reader. The new > > struct is heavily duplicated with XLogReaderState and I'm not > > sure the rason why the XLogReadPos is needed. > > Any other opinions, or thoughts? > > The focus is on the stability of v12 for the next couple of months, so > please make sure to register it to the next CF if you want feedback.
ok, will do. (A link to mailing list is needed for the CF entry, so I had to post something anyway :-) Since I don't introduce any kind of "cool new feature" here, I believe it did not disturb much.) > Here are some basic thoughts after a very quick lookup. > ... Thanks. -- Antonin Houska Web: https://www.cybertec-postgresql.com