Hi, On 2019-05-17 16:56:04 -0700, Ashwin Agrawal wrote: > Question on the patch, if not too late > Why call table_beginscan() in TidNext() and not in ExecInitTidScan() ? > Seems cleaner to have it in ExecInitTidScan().
Largely because it's symmetrical to where most other scans are started ( c.f. nodeSeqscan.c, nodeIndexscan.c). But also, there's no need to incur the cost of a smgrnblocks() etc when the node might never actually be reached during execution. Greetings, Andres Freund
