On Wed, May 22, 2019 at 7:41 AM Andres Freund <and...@anarazel.de> wrote:> > On 2019-05-21 12:19:18 -0700, Andres Freund wrote: > > Roughly like in the attached? > > > -check: test.sh all > > - MAKE=$(MAKE) bindir="$(tbindir)" libdir="$(tlibdir)" > > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > > +check: test.sh all temp-install > > + MAKE=$(MAKE) $(with_temp_install) > > bindir=$(abs_top_builddir)/tmp_install/$(bindir) MAKE=$(MAKE) > > EXTRA_REGRESS_OPTS="$(EXTRA_REGRESS_OPTS)" $(SHELL) $< $(DOINST) > > minus the duplicated MAKE=$(MAKE) of course.
After these commits (and Tom's commit "Un-break pg_upgrade regression test."), cfbot broke: (using postmaster on /tmp/pg_upgrade_check-YGuskp, port 54464) ============== dropping database "regression" ============== sh: 1: /usr/local/pgsql/bin/psql: not found command failed: "/usr/local/pgsql/bin/psql" -X -c "DROP DATABASE IF EXISTS \"regression\"" "postgres" make[1]: *** [installcheck-parallel] Error 2 make[1]: Leaving directory `/home/travis/build/postgresql-cfbot/postgresql/src/test/regress' Before that it had been running happily like this: ./configure --enable-debug --enable-cassert --enable-tap-tests --with-tcl --with-python --with-perl --with-ldap --with-openssl --with-gssapi --with-icu && echo "COPT=-Wall -Werror" > src/Makefile.custom && make -j4 all contrib docs && make check-world I added --prefix=$HOME/something and added "make install" before "make check-world", and now it's happy again. Was that expected? -- Thomas Munro https://enterprisedb.com