I wrote: > I propose that we change src/tools/pginclude/cpluspluscheck so that > it searches basically everywhere: > -for f in `find src/include src/interfaces/libpq/libpq-fe.h > src/interfaces/libpq/libpq-events.h -name '*.h' -print | \ > +for f in `find src contrib -name '*.h' -print | \
After further experimentation with that, it seems like we'll have to continue to exclude src/bin/pg_dump/*.h from the C++ check. pg_dump uses "public" and "namespace" as field names in various structs, both of which are C++ keywords. Changing these names would be quite invasive, and at least in the short run I see no payoff for doing so. ecpg/preproc/type.h is also using "new" as a field name, but it looks like there are few enough references that renaming that field isn't unreasonable. There are various other minor issues, but they generally look fixable with little consequence. regards, tom lane