Meskes-san

> This looks good to me. It passes all my tests, too.
> 
> There were two minor issues, the regression test did not run and gcc
> complained about the indentation in ECPGprepare(). Both I easily fixed.

Thank you so much !

> > (2)
> > I found some bugs (two types). I didn't fix them and only avoid bison
> > error.
> >
> > Type1. Bugs or intentional unsupported features.
> >   - EXPLAIN EXECUTE
> >   - CREATE TABLE AS with using clause
> > ...
> 
> Please send a patch. I'm on vacation and won't be able to spend time on
> this for the next couple of weeks.

I begin to fix it. It may spend a while (1 or 2 week).


> > Type2. In multi-bytes encoding environment, a part of character of
> > message is cut off.
> >
> >   It may be very difficult to fix. I pretend I didn't see it for a
> > while.
> > ...
> 
> Hmm, any suggestion?

I think that it's better to import length_in_encoding() defined in 
backend/utils/mb/mbutils.c into client side.
Just an idea.


Regards
Ryo Matsumura

Reply via email to