On 2019-07-05 01:33, Noah Misch wrote: > I just saw this proposal. The undefined behavior in question is strictly > academic. These changes do remove the need for new users to discover > -fno-sanitize=nonnull-attribute, but they make the code longer and no clearer. > Given the variety of code this touches, I expect future commits will > reintroduce the complained-of usage patterns, prompting yet more commits to > restore the invariant achieved here. Hence, I'm -0 for this change.
This sanitizer has found real problems in the past. By removing these trivial issues we can then set up a build farm animal or similar to automatically check for any new issues. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
