On Fri, Mar 1, 2019 at 7:11 AM Jeff Janes <jeff.ja...@gmail.com> wrote: > I'm adding it to the commitfest targeting v13. I'm more interested in > feedback on the conceptual issues rather than stylistic ones, as I would > probably merge the two functions together before proposing something to > actually be committed.
>From the trivialities department, this patch shows up as a CI failure with -Werror, because there is no declaration for genericcostestimate2(). I realise that's just a temporary name in a WIP patch anyway so this isn't useful feedback, but for the benefit of anyone going through CI failures in bulk looking for things to complain about: this isn't a real one. -- Thomas Munro https://enterprisedb.com
