On Tue, Jul 2, 2019 at 6:29 PM Amit Langote <amitlangot...@gmail.com> wrote: > 0001 - fix partitionwise join to work correctly with n-way joins of > which some are full joins (+ cosmetic improvements around the code > that was touched)
Here are my comments about the cosmetic improvements: they seem pretty large to me, so I'd make a separate patch for that. In addition, I'd move have_partkey_equi_join() and match_expr_to_partition_keys() to relnode.c, because these functions are only used in that file. Best regards, Etsuro Fujita