On Tue, Jul 16, 2019 at 8:39 AM Robert Haas <robertmh...@gmail.com> wrote: > Thomas has already objected to another proposal to add functions that > turn 32-bit XIDs into 64-bit XIDs. Therefore, I feel confident in > predicting that he will likewise object to GetEpochForXid. I think > this needs to be changed somehow, maybe by doing what the XXX comment > you added suggests.
Perhaps we should figure out how to write GetOldestFullXmin() and friends. For FinishPreparedTransaction(), the XXX comment sounds about right (TwoPhaseFileHeader should hold an fxid). -- Thomas Munro https://enterprisedb.com
