Hi Asif

Interesting proposal.  Bulk of the work in a backup is transferring files
from source data directory to destination.  Your patch is breaking this
task down in multiple sets of files and transferring each set in parallel.
This seems correct, however, your patch is also creating a new process to
handle each set.  Is that necessary?  I think we should try to achieve this
using multiple asynchronous libpq connections from a single basebackup
process.  That is to use PQconnectStartParams() interface instead of
PQconnectdbParams(), wich is currently used by basebackup.  On the server
side, it may still result in multiple backend processes per connection, and
an attempt should be made to avoid that as well, but it seems complicated.

What do you think?

Asim

Reply via email to