> On Mon, Aug 5, 2019 at 10:38 PM Dmitry Dolgov <9erthali...@gmail.com> wrote: > > Of course we can modify it to read a whole page and leave visibility check > for the code after `index_getnext_tid` (although in case if we know that all > tuples on this page are visilbe I guess it's not strictly necessary, but we > still get improvement from skipping itself).
Sorry for long delay. Here is more or less what I had in mind. After changing read_closest to read the whole page I couldn't resist to just merge it into readpage itself, since it's basically the same. It could raise questions about performance and how intrusive this patch is, but I hope it's not that much of a problem (in the worst case we can split it back). I've also added few tests for the issue you've mentioned. Thanks again, I'm appreciate how much efforts you put into reviewing!
v24-0001-Index-skip-scan.patch
Description: Binary data
