Hi Fabien, On Wed, Sep 18, 2019 at 3:49 AM Fabien COELHO <coe...@cri.ensmp.fr> wrote: > Attached v9:
Thanks. This seems to work well. Couple of nitpicks on parameter error messages. + fprintf(stderr, "invalid partition type, expecting \"range\" or \"hash\"," How about "partitioning method" instead of "partition type"? + fprintf(stderr, "--partition-method requires actual partitioning with --partitions\n"); Assuming that this error message is to direct the user to fix a mistake they might have inadvertently made in specifying --partitions, I don't think the message is very clear. How about: "--partition-method requires --partitions to be greater than zero" but this wording might suggest to some users that some partitioning methods do allow zero partitions. So, maybe: "specifying --partition-method requires --partitions to be greater than zero" Thanks, Amit
