On Mon, Sep 23, 2019 at 10:28:09AM +0200, Tels wrote: > Moin, > > On 2019-09-22 23:58, David Fetter wrote: > > On Sat, Sep 21, 2019 at 07:29:25AM +0100, Andrew Gierth wrote: > > > >>>>> "David" == David Fetter <da...@fetter.org> writes: > > > Fixed. > > Good work, more performance is sure nice :) > > Noticed one more thing in the patch: > > > - *start++ = *a; > > - *a-- = swap; > > + memcpy(pos - 2, DIGIT_TABLE + c, 2); > > + i += 2; > > } > > + else > > + *a = (char) ('0' + value2); > > + > > + return olength; > > } > > The line "i += 2;" modifies i, but i is never used again nor returned.
I found a similar one in a similar function, and removed it, too. Best, David. -- David Fetter <david(at)fetter(dot)org> http://fetter.org/ Phone: +1 415 235 3778 Remember to vote! Consider donating to Postgres: http://www.postgresql.org/about/donate