On Thu, Oct 10, 2019 at 5:52 AM Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > > On 2019-09-30 03:48, Fujii Masao wrote: > > Also we need to do the same thing for other recovery options like > > restore_command. Attached is the patch which makes crash recovery > > ignore restore_command and recovery_end_command. > > This patch looks correct to me.
Thanks for the review! I committed the patch. > Do we need to handle archive_cleanup_command? Perhaps not. No, because archive_command is basically executed by checkpointer and this process cannot be invoked in crash recovery case. > A check in recoveryApplyDelay() might be necessary. Yes! We are discussing this issue at https://www.postgresql.org/message-id/CAHGQGwEyD6HdZLfdWc+95g=vqfpr4zql4n+yhxqggegjasv...@mail.gmail.com Regards, -- Fujii Masao