On Mon, Oct 28, 2019 at 4:43 AM Peter Eisentraut <peter.eisentr...@2ndquadrant.com> wrote: > Here is a new implementation that works just like that.
This looks like a marked notational improvement. With the patch: [rhaas pgsql]$ git grep PG_CATCH | wc -l 102 [rhaas pgsql]$ git grep PG_FINALLY | wc -l 55 I'm actually a bit surprised that the percentage of cases that could be converted to use PG_FINALLY wasn't even higher than that. In theory, the do_rethrow variable could conflict with a symbol declared in the surrounding scope, but that doesn't seem like it's a problem worth getting worked up about. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company