On Sun, 3 Nov 2019 at 21:47, Thomas Munro <thomas.mu...@gmail.com> wrote:
> On Thu, Oct 31, 2019 at 3:03 AM Dave Cramer <davecra...@gmail.com> wrote: > > Ok, I've rebased and reverted logicalrep_read_insert > > Hi Dave, > > From the code style police (actually just from cfbot, which is set up > to complain about declarations after statements, a bit of C99 we > aren't ready for): > > proto.c:557:6: error: ISO C90 forbids mixed declarations and code > [-Werror=declaration-after-statement] > int len = pq_getmsgint(in, 4); /* read length */ > ^ > proto.c:573:6: error: ISO C90 forbids mixed declarations and code > [-Werror=declaration-after-statement] > int len = pq_getmsgint(in, 4); /* read length */ > ^ > Thomas, Thanks for the review. See attached
0005-Remove-C99-declaration-and-code.patch
Description: Binary data
