On Tue, Nov 5, 2019 at 9:22 AM Michael Paquier <mich...@paquier.xyz> wrote: > On Thu, Oct 31, 2019 at 05:55:55PM +0900, Michael Paquier wrote: > > Thanks. I exactly did the same thing on my local branch. > > Hearing nothing more, I have done some adjustments to the patch and > committed it.
Thank you. > Please note that I have not switched the old interface > to be static to reloptions.c as if you look closely at reloptions.h we > allow much more flexibility around HANDLE_INT_RELOPTION to fill and > parse the reloptions in custom AM. AM maintainers had better use the > new interface, but there could be a point for more customized error > messages. I looked around but don't understand why these macros need to be exposed. I read this comment: * Note that this is more or less the same that fillRelOptions does, so only * use this if you need to do something non-standard within some option's * code block. but don't see how an AM author might be able to do something non-standard with this interface. Maybe Alvaro knows this better. Thanks, Amit
