On 11/6/19 6:27 PM, Michael Paquier wrote:
On Wed, Nov 06, 2019 at 04:16:14PM -0800, Mark Dilger wrote:
While working on cleaning up the SPI interface, I found that one of the SPI
error codes, SPI_ERROR_COPY, is never encountered in any test case when
running `make check-world`. This case is certainly reachable by a user, as
is shown in the attached patch. Is this tested from some other
infrastructure?
Hard to say, but I think that it would be good to test that part
independently anyway. The transaction part close by is actually
getting stressed with plpgsql_transaction, so the split done in your
patch looks fine. I'll look at it again in a couple of days to
double-check for missing spots, and commit it if there are no
objections.
Thanks for reviewing!
--
Mark Dilger
