On Thu, Nov 14, 2019 at 05:49:12PM -0500, Tom Lane wrote: > Bruce Momjian <br...@momjian.us> writes: > > On Thu, Nov 14, 2019 at 04:06:52PM -0300, Alvaro Herrera wrote: > >> BTW, how is one supposed to "manually upgrade databases that use > >> contrib/isb"? This part is not very clear. > > > I thought you would dump out databases that use isn, drop those > > databases, use pg_upgrade for the remaining databases, then load the > > dumped database. Attached is a patch that improves the wording. > > That's better wording, but do we need similar for any of the other > not-supported checks?
I don't think so. The other checks are checking for the _use_ of certain things in user objects, and the user objects can be dropped, while this check checks for the existence of _functions_ from an extension that must be uninstalled. I assume the extension can be uninstalled in the database, but I assume something uses it and that telling people to find all the users of the extension then dropping it is too complex to describe. -- Bruce Momjian <br...@momjian.us> http://momjian.us EnterpriseDB http://enterprisedb.com + As you are, so once was I. As I am, so you will be. + + Ancient Roman grave inscription +