On Sat, Nov 16, 2019 at 7:01 AM vignesh C <vignes...@gmail.com> wrote: > > On Tue, Nov 12, 2019 at 11:19 AM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > On Tue, Nov 12, 2019 at 6:33 AM vignesh C <vignes...@gmail.com> wrote: > > > > > > > > > Thanks Amit for your comments. Please find the updated patch which > > > does not include the changes mentioned above. > > > > > > > Thanks for working on this. I have pushed your latest patch. > > > > Thanks Amit for pushing the patch. I have re-verified and found that > changes need to be done in few more places. The main changes are made > in the header file and plpython source files. The attached patch > handles the same. I have verified make check and make check-world > including --with-python & --with-perl in the following: > CentOS Linux release 7.7.1908 > Red Hat Enterprise Linux Server release 7.1 > > I have verified including --llvm in CentOS Linux release 7.7.1908. >
Thanks for finding the remaining places, the patch looks good to me. I hope this covers the entire code. BTW, are you using some script to find this or is this a result of manual inspection of code? I have modified the commit message in the attached patch. I will commit this early next week unless someone else wants to review it. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
0001-Make-the-order-of-the-header-file-includes-consisten.patch
Description: Binary data
