Bonjour Michaƫl,
Committed the patch after splitting things into two commits and after testing things from Linux and from a Windows console: the actual refactoring and the pgbench changes.I have found that we have a useless declaration of CancelRequested in common.h, which is already part of cancel.h.
Ok.
On top of that I think that we need to rework a bit the header inclusions of bin/scripts/, as per the attached.
Looks fine to me: patch applies, compiles, runs. -- Fabien.