On Fri, Dec 6, 2019 at 1:35 AM Rushabh Lathia <rushabh.lat...@gmail.com> wrote: > There is one review comment from Jeevan Chalke, which still pending > to address is: > >> 4. >> Why we need a "File" at the start of each entry as we are adding files only? >> I wonder if we also need to provide a tablespace name and directory marker so >> that we have "Tablespace" and "Dir" at the start. > > Sorry, I am not quite sure about this, may be Robert is right person > to answer this.
I did it that way for extensibility. Notice that the first and last line of the manifest begin with other words, so someone parsing the manifest can identify the line type by looking just at the first word. Someone might in the future find some need to add other kinds of lines that don't exist today. "Tablespace" and "Dir" are, in fact, pretty good examples of things that someone might want to add in the future. I don't really see a clear need for either one today, although maybe somebody else will, but I think we should leave ourselves room to add such things in the future. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
