On Wed, Dec 25, 2019 at 2:01 PM Fujii Masao <masao.fu...@gmail.com> wrote: > > Hi, > > I'd like to propose to add pg_file_sync() function into contrib/adminpack. > This function fsyncs the specified file or directory named by its argument. > IMO this is useful, for example, when you want to fsync the file that > pg_file_write() writes out or that COPY TO exports the data into, > for durability. Thought?
+1, that seems like a useful wrapper. Looking at existing functions, I see that there's a pg_file_rename() in adminpack, but it doesn't use durable_rename nor does it try to perform any fsync. Same for pg_file_unlink vs. durable_unlink. It's probably worth fixing that at the same time?
