On 2019-12-06 18:43, Joe Nelson wrote:
I see this patch has been moved to the next commitfest. What's the next step, does it need another review?
I think you need to promote your patch better. The thread subject and the commit fest entry title are somewhat nonsensical and no longer match what the patch actually does. The patch contains no commit message and no documentation or test changes, so it's not easy to make out what it's supposed to do or verify that it does so correctly. A reviewer would have to take this patch on faith or manually test every single command line option to see what it does. Moreover, a lot of this error message tweaking is opinion-based, so it's more burdensome to do an objective review. This patch is competing for attention against more than 200 other patches that have more going for them in these aspects.
-- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
