On 2020-Jan-14, vignesh C wrote: > On Mon, Jan 13, 2020 at 7:52 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > > > > vignesh C <vignes...@gmail.com> writes: > > > On Thu, Sep 26, 2019 at 7:17 PM Luis Carril <luis.car...@swarm64.com> > > > wrote: > > >>> Your patch is failing the pg_dump TAP tests. Please use > > >>> configure --enable-tap-tests, fix the problems, then resubmit. > > > > >> Fixed, I've attached a new version. > > > > > Will it be possible to add a test case for this, can we validate by > > > adding one test? > > > > Isn't the change in the TAP test output sufficient? > > I could not see any expected file output changes in the patch. Should > we modify the existing test to validate this.
Yeah, I think there should be at least one regexp in t/002_pg_dump.pl to verify ALTER FOREIGN TABLE is being produced. I wonder if Tom is thinking about Luis' other pg_dump patch for foreign tables, which includes some changes to src/test/modules/test_pg_dump. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services