On Tue, Feb 18, 2020 at 1:11 PM Amit Langote <amitlangot...@gmail.com> wrote: > On Tue, Feb 18, 2020 at 6:56 AM Alvaro Herrera <alvhe...@2ndquadrant.com> > wrote: > @@ -16541,7 +16493,7 @@ CloneRowTriggersToPartition(Relation parent, > Relation partition) > * > * However, if our parent is a partitioned relation, there might be > > This is existing text, but should really be: > > However, if our parent is a *partition* itself, there might be > > (Sorry, I forgot to report this when the bug-fix went in couple months ago.) > > * internal triggers that need cloning. In that case, we must skip > - * clone it if the trigger on parent depends on another trigger. > + * cloning it if the trigger on parent depends on another trigger. > > 2nd sentence seems unclear to me. Does the following say what needs > to be said here: > > * However, if our parent is a partition itself, there might be > * internal triggers that need cloning. For example, triggers on the > * parent that were in turn cloned from its own parent are marked > * internal, which too must be cloned to the partition.
Or: * However, if our parent is a partition itself, there might be * internal triggers that must not be skipped. For example, triggers * on the parent that were in turn cloned from its own parent are * marked internal, which must be cloned to the partition. Thanks, Amit