Michael Paquier <mich...@paquier.xyz> writes: > On Fri, Feb 28, 2020 at 01:45:29PM -0500, Tom Lane wrote: >> After poking around, I see there aren't any other callers. But I think >> that the cause of this bug is clearly failure to think carefully about >> the different cases that isTempNamespaceInUse is recognizing, so that >> the right way to fix it is more like the attached.
> Good idea, thanks. Your suggestion looks good to me. Will push that, thanks for looking. >> In the back branches, we could leave isTempNamespaceInUse() in place >> but unused, just in case somebody is calling it. I kind of doubt that >> anyone is, given the small usage in core, but maybe. > I doubt that there are any external callers, but I'd rather leave the > past API in place on back-branches. Agreed. regards, tom lane