Hi,
On Wed, Mar 18, 2020 at 04:28:34AM +0000, Shinoda, Noriyoshi (PN Japan A&PS
Delivery) wrote:
Hello,
I found a missing column description in the pg_statistic_ext catalog document
for this new feature.
The attached patch adds a description of the 'stxstattarget' column to
pg_statistic_ext catalog's document.
If there is a better explanation, please correct it.
Thanks for the report. Yes, this is clearly an omission. I think it
would be better to use wording similar to attstattarget, per the
attached patch. That is, without reference to ALTER STATISTICS and
better explaination of what positive/negative values do. Do you agree?
regards
Regards,
Noriyoshi Shinoda
-----Original Message-----
From: Tomas Vondra [mailto:tomas.von...@2ndquadrant.com]
Sent: Wednesday, September 11, 2019 7:28 AM
To: Alvaro Herrera <alvhe...@2ndquadrant.com>
Cc: Thomas Munro <thomas.mu...@gmail.com>; Jamison, Kirk <k.jami...@jp.fujitsu.com>; Dean
Rasheed <dean.a.rash...@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Multivariate MCV list vs. statistics target
On Tue, Sep 03, 2019 at 02:38:56PM -0400, Alvaro Herrera wrote:
On 2019-Aug-01, Tomas Vondra wrote:
I'll move it to the next CF. Aside from the issues pointed by
Kyotaro-san in his review, I still haven't made my mind about whether
to base the use statistics targets set for the attributes. That's
what we're doing now, but I'm not sure it's a good idea after adding separate
statistics target.
I wonder what Dean's opinion on this is, as he added the current logic.
Latest patch no longer applies. Please update. And since you already
seem to have handled all review comments since it was Ready for
Committer, and you now know Dean's opinion on the remaining question,
please get it pushed.
OK, I've pushed this the patch, after some minor polishing.
regards
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/doc/src/sgml/catalogs.sgml b/doc/src/sgml/catalogs.sgml
index c6f95fa688..64614b569c 100644
--- a/doc/src/sgml/catalogs.sgml
+++ b/doc/src/sgml/catalogs.sgml
@@ -6452,6 +6452,22 @@ SCRAM-SHA-256$<replaceable><iteration
count></replaceable>:<replaceable>&l
<entry>Owner of the statistics object</entry>
</row>
+ <row>
+ <entry><structfield>stxstattarget</structfield></entry>
+ <entry><type>int4</type></entry>
+ <entry></entry>
+ <entry>
+ <structfield>stxstattarget</structfield> controls the level of detail
+ of statistics accumulated for this statistics object by
+ <xref linkend="sql-analyze"/>.
+ A zero value indicates that no statistics should be collected.
+ A negative value says to use the system default statistics target.
+ Positive values <structfield>stxstattarget</structfield>
+ determine the target number of <quote>most common values</quote>
+ to collect.
+ </entry>
+ </row>
+
<row>
<entry><structfield>stxkeys</structfield></entry>
<entry><type>int2vector</type></entry>
