On Wed, 18 Mar 2020 at 04:24, Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Thanks Arseny and Masahiko, I pushed this patch just now. I changed > some comments while at it, hopefully they are improvements. > > On 2020-Mar-09, Masahiko Sawada wrote: > > > ctx = CreateInitDecodingContext(plugin, NIL, > > - false, /* do not build snapshot */ > > + false, /* do not build data snapshot */ > > restart_lsn, > > logical_read_local_xlog_page, NULL, NULL, > > NULL); > > > > I'm not sure this change makes the comment better. Could you elaborate > > on the motivation of this change? > > I addressed this issue by adding a comment in CreateInitDecodingContext > to explain the parameter, and then reference that comment's terminology > in this call. I think it ends up clearer overall -- not that this whole > area is at all particularly clear. > > Thanks again. >
Thank you for committing the patch! That changes look good to me. Regards, -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Masahiko Sawada http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
