Hello
I was inactive for a while... Sorry.
>> BTW, I recheck the patchset.
>> I think codes are ready for committer but should we modify the
>> documentation?
>> {min,max,mean,stddev}_time is now obsoleted so it is better to modify it to
>> {min,max,mean,stddev}_exec_time and add {min,max,mean,stddev}_plan_time.
>
> Oh indeed, I totally forgot about this. I'm attaching v8 with updated
> documentation that should match what was implemented since some versions.
Yet another is missed in docs: total_time
I specifically verified that the new loaded library works with the old version
of the extension in the database. I have not noticed issues here.
> 2.2% is a bit large but I think it is still acceptable because people using
> this feature
> might take account that some overhead will happen for additional calling of a
> gettime function.
I will be happy even with 10% overhead due to enabled track_planning... (but in
this case disabled by default) log_min_duration_statement = 0 with log parsing
is much more expensive.
I think 1-2% is acceptable and we can set track_planning = on by default as
patch does.
> * Rows for executor time are changed from {total/min/max/mean/stddev}_time to
> {total/min/max/mean/stddev}_exec_time.
Maybe release it as 2.0 version instead of minor update 1.18?
regards, Sergei
