On 3/23/20 1:33 AM, James Coleman wrote:
So on the face of it we have a bit of a no-win situation. The function tuple_sort_method_name returns a const, but lappend wants a non-const. I'm not sure what the project style preference is here: we could cast the result as (char *) to drop the const qualifier, but that's frowned upon some places. Alternatively we could make a new non-const copy of string. Which is preferable in the postgres project style?
The PostgreSQL has places where const is explicitly casted away with the unconstify() macro, so unless you can find a better solution that is probably an ok option.
Andreas
