On 2020-Mar-27, Sergei Kornilov wrote: > Hello > > > I realized that the reason the tests broke after Sergei's patch is that > > recovery/t/001_stream_rep.pl's get_slot_xmins() is broken for temp > > walreceiver slots, since it's using the non-temp name it tries to give > > to the slot, rather than the temp name under which it is actually > > created. The workaround proposed by 0002 is to edit standby_1's config > > to set walreceiver's slot to be non-temp. > > This is bug in behavior, not in tests. > We need walrcv->is_temp_slot = false; somewhere in RequestXLogStreaming to > works correctly. > > HEAD is not affected since primary_slot_name cannot be changed online.
I pushed the wal_receiver_create_temp_slot bugfix, because I realized after looking for long enough at WalReceiverMain() that the code was beyond saving. I'll be pushing the rest of this later today. Thanks, -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
