On Wed, Apr 1, 2020 at 4:29 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > v9-0005-Keep-track-of-WAL-usage-in-pg_stat_statements >
One more comment related to this patch. + + snprintf(buf, sizeof buf, UINT64_FORMAT, tmp.wal_bytes); + + /* Convert to numeric. */ + wal_bytes = DirectFunctionCall3(numeric_in, + CStringGetDatum(buf), + ObjectIdGetDatum(0), + Int32GetDatum(-1)); + + values[i++] = wal_bytes; I see that other places that display uint64 values use BIGINT datatype in SQL, so why can't we do the same here? See the usage of queryid in pg_stat_statements or internal_pages, *_pages exposed via pgstatindex.c. -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
