On Tue, Apr 7, 2020 at 8:30 PM Juan José Santamaría Flecha <juanjo.santama...@gmail.com> wrote: > > * I think you could save a couple of code lines, and make it clearer, by > merging both tests on _MSC_VER into a single #if... #else and leaving as > common code: > + } > + else > + return NULL; > +#endif /*_MSC_VER && _MSC_VER < 1900*/ > > * The logic on "defined(_MSC_VER) && (_MSC_VER >= 1900)" is defined as > "_WIN32_WINNT >= 0x0600" on other parts of the code. I would recommend using > the later. >
I see that we have used _MSC_VER form of checks in win32_langinfo (chklocale.c) for a similar kind of handling. So, isn't it better to be consistent with that? Which exact part of the code you are referring to? -- With Regards, Amit Kapila. EnterpriseDB: http://www.enterprisedb.com
