On Fri, Apr 10, 2020 at 02:48:05PM -0700, Andres Freund wrote: > I don't agree with any of that. Combining the manifest validation with > checksum validation halves the IO. It allows to offload some of the > expense of verifying page level checksums from the primary. > > And all of the operations require iterating through data directories, > classify files that are part / not part of a normal data directory, etc.
The last time we had the idea to use _verify_ in a tool name, the same tool has been renamed one year after as we found new use cases for it, aka pg_checksums. Cannot the same be said with pg_validatebackup? It seems to me that it could be interesting for some users to build a manifest after a backup is taken, using something like a --build option with pg_validatebackup. -- Michael
signature.asc
Description: PGP signature