On 2020-Apr-08, Antonin Houska wrote: > Specifically for 2PC, isn't it better to close some OS-level FD of an > unrelated table scan and then succeed than to ERROR immediately? Anyway, > 0dc8ead46 hasn't changed this.
I think for full generality of the interface, we pass a "close" callback in addition to the "open" callback. But if we were to pass it only for WALRead, then there would be no way to call it during XLogReaderFree. I think the fix Andres applied is okay as far as it goes, but for the long term we may want to change the interface even further -- maybe by having these functions be part of the XLogReader state struct. I have this code paged out of my head ATM, but maybe tomorrow I can give it a little think. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
