Tomas Vondra <tomas.von...@2ndquadrant.com> writes: > On Thu, Apr 23, 2020 at 03:28:21PM +0800, Richard Guo wrote: >> A minor comment is that I don't think we need to strip relabel >> explicitly before calling pull_varnos(), because this function would >> recurse into T_RelabelType nodes.
> Hmmm, yeah. I think you're right that's unnecessary. I misread the > walker function, I think. +1, might as well simplify the code. >> Also do we need to call bms_free(varnos) for each pathkey here to avoid >> waste of memory? > I don't think so. It wouldn't hurt, but we don't do that for other > pull_vernos calls either AFAICS. Yeah, the planner is generally pretty profligate of memory, and these bitmaps aren't likely to be huge anyway. regards, tom lane