On Thu, May 28, 2020 at 3:15 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > On Thu, May 28, 2020 at 12:57 PM Dilip Kumar <dilipbal...@gmail.com> wrote: > > > > On Tue, May 26, 2020 at 3:04 PM Amit Kapila <amit.kapil...@gmail.com> wrote: > > > > > > Why we need memory-related to subxacts till the worker is alive? As > > > we have now, after reading subxact info (subxact_info_read), we need > > > to ensure that it is freed after its usage due to which we need to > > > remember and perform pfree at various places. > > > > > > I think we should once see the possibility that such that we could > > > switch to this new context in start stream message and reset it in > > > stop stream message. That might help in avoiding > > > MemoryContextSwitchTo TopMemoryContext at various places. > > > > Ok, I understand, I think subxacts can be allocated in new > > LogicalStreamingContext which we can reset at the stream stop. How > > about xids? > > > > How about storing xids in ApplyContext? We do store similar lifespan > things in that context, for ex. see store_flush_position.
That sounds good to me, I will make this change in the next patch set, along with other changes. -- Regards, Dilip Kumar EnterpriseDB: http://www.enterprisedb.com
