Hello hackers, We already have pg_xact_commit_timestamp() that returns the timestamp of the commit. It may be better to have one single function returning both timestamp and origin for a given transaction ID.
A second thing is that TransactionIdGetCommitTsData() was introdued in core(73c986add). It has only one caller pg_xact_commit_timestamp() which passes RepOriginId as NULL, making last argument to the TransactionIdGetCommitTsData() a dead code in core. Quick code search shows that it is getting used by pglogical (caller: https://sources.debian.org/src/pglogical/2.3.2-1/pglogical_conflict.c/?hl=509#L509). CCing Craig Ringer and Petr Jelinek for the inputs. Warm Regards, Madan Kumar K "There is no Elevator to Success. You have to take the Stairs"
