On 2020-Jul-09, Peter Eisentraut wrote: > On 2020-07-08 06:42, Fabien COELHO wrote: > > > What do you think about this patch to reorganize the existing code from > > > that > > > old commit? > > > > I think it is a definite further improvement. > > > > Patch applies cleanly, compiles, global & pg_dump tap test ok, looks ok to > > me. > > Thanks. I have committed that, and attached is my original patch adjusted > to this newer style.
Thanks, I too prefer the style where queries are split in lines instead of a single very long one, at least when looking at log_statement=all lines generated by pg_dump runs. It's not a *huge* usability improvement, but I see no reason to make things worse. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
