On Mon, Jul 27, 2020 at 11:24 AM Alvaro Herrera <alvhe...@2ndquadrant.com> wrote: > > Are you proposing that I just put the prototype in miscadmin.h, while > > leaving the implementation where it is (in nodeHash.c)? > > Yes, that's in the part of my reply you didn't quote: > > : It remains strange to have the function in executor > : implementation, but I don't offhand see a better place, so maybe it's > : okay where it is.
Got it. I tried putting the prototype in miscadmin.h, and I now agree that that's the best way to do it -- that's how I do it in the attached revision. No other changes. The v4-0001-Remove-hashagg_avoid_disk_plan-GUC.patch changes are surprisingly complicated. It would be nice if you could take a look at that aspect (or confirm that it's included in your review). -- Peter Geoghegan
v4-0001-Remove-hashagg_avoid_disk_plan-GUC.patch
Description: Binary data
v4-0002-Add-hash_mem_multiplier-GUC.patch
Description: Binary data
