On Wed, Aug 5, 2020 at 1:30 PM Tom Lane <t...@sss.pgh.pa.us> wrote: > I don't like this patch at all though; I do not think it is being nearly > careful enough to ensure that it's matched the surviving relation OIDs > correctly. In particular it blithely assumes that a zero in relid_map > *must* match the immediately next entry in partdesc->oids, which is easy > to break if the new partition is adjacent to the one the planner managed > to prune. So I think we should do it more like the attached.
Ooh, nice catch. > I'm strongly tempted to convert the trailing Assert to an actual > test-and-elog, too, but didn't do so here. I was thinking about that, too. +1 for taking that step. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company
